Skip to content

Conversation

@regulus79
Copy link
Member

This PR adds the ability to select multiple mixer channels at once and do simple operations on all of them, such as sending, muting, deleting, and changing color.

Implementation

  • The currently selected mixer channels are stored in a std::set within MixerChannelView
  • Lots of methods which used to work on a single channel have been changed to work with the entire selection of channels In particular,
    • Send/unsend
    • Changing color
    • Moving left/right
    • Deleting selected channels
    • Muting/soloing

Known Bugs

  • Bulk solo is buggy
  • Bulk moving left/right is buggy when some unselected channels have send/receives. I'm not sure why.

Now that I think about it, this code is really messy and this probably isn't the best way to handle it. If you all don't think this is a good PR, I can wait for someone else to do it better lol.

@szeli1
Copy link
Contributor

szeli1 commented Mar 4, 2025

I would like to mention that #7734 if implemented will make it so this needs to be updated. I don't know when it will happen or if others agree.

@bratpeki
Copy link
Member

bratpeki commented Mar 4, 2025

This probably has conflicts with #7636 now. More than happy to test, though.

@bratpeki bratpeki self-assigned this Mar 4, 2025
@regulus79 regulus79 added gui rework required Pull requests which must be reworked to make it able to merge or review labels Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gui rework required Pull requests which must be reworked to make it able to merge or review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants