Skip to content

Conversation

@rubiefawn
Copy link
Contributor

@rubiefawn rubiefawn commented Mar 14, 2025

Replaces the .png raster assets for the native Dispersion plugin with .svg vector assets. nothing! it's all CSS now.

Note

Part of #7767

@rubiefawn
Copy link
Contributor Author

rubiefawn commented Mar 14, 2025

Text in SVG assets isn't working properly at the moment (the DC button on the right, ignore the "AMOUNT" label). Should such buttons even be SVG since they won't inherit the correct font? Should they be styled through CSS instead?

Edit: This button is now styled through CSS.

image

@rubiefawn rubiefawn force-pushed the feat/dispersion-svg branch from c877224 to 711fed1 Compare March 15, 2025 02:20
@rubiefawn rubiefawn mentioned this pull request Mar 19, 2025
5 tasks
@rubiefawn rubiefawn marked this pull request as ready for review March 22, 2025 05:03
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looks okay overall. Had a few suggestions/questions though:

@sakertooth
Copy link
Contributor

Also wondering if any of the other plugins you've switched to SVG could use the same CSS treatment, or should they be left as SVG?

@rubiefawn
Copy link
Contributor Author

rubiefawn commented May 28, 2025

Yes, several of them should be changed to pure CSS. I'll do those all together in a separate PR.

@bratpeki
Copy link
Member

bratpeki commented Jun 4, 2025

2025-06-04-093115_640x480_scrot
2025-06-04-093119_640x480_scrot

Very odd. Tested on the x86 Linux AppImage.

@bratpeki bratpeki self-assigned this Jun 4, 2025
@bratpeki
Copy link
Member

bratpeki commented Jun 4, 2025

.svg vector assets. nothing! it's all CSS now.

Could you elaborate on this?

@rdrpenguin04
Copy link
Contributor

I think the elaboration is that the Dispersion plugin didn't have many PNG assets; one of them was a button with text on it, so that was converted to a button with text on it, and one of them was a solid background color, so it was converted to a solid background color.

The only thing that was changed into an SVG was the logo, which is the same LMMS logo SVG everything else is using.

@rubiefawn rubiefawn force-pushed the feat/dispersion-svg branch from 7af0f78 to f217eef Compare June 9, 2025 18:59
@rubiefawn rubiefawn force-pushed the feat/dispersion-svg branch from f217eef to 91889cc Compare June 9, 2025 19:09
@rubiefawn
Copy link
Contributor Author

There was a conflict with #7525 and I botched my merge, now the layout is all scrambled, yuck. I'll take a look at fixing the layout later tonight.

rubiefawn added 2 commits June 9, 2025 13:33
In this commit, the layout will still be all controls in a single row.
This will change later.
@bratpeki
Copy link
Member

2025-06-04-093115_640x480_scrot 2025-06-04-093119_640x480_scrot

Very odd. Tested on the x86 Linux AppImage.

@rubiefawn Has the missing icon been addressed?

@rubiefawn
Copy link
Contributor Author

rubiefawn commented Jun 12, 2025

Not yet, I haven't looked into it yet. Fixed

@bratpeki
Copy link
Member

Tested it, looks great! Had a quick look at the code, just to make sure only GUI is affected, everything looks fine to me. Just for reference, the plugin looks like this now:

2025-06-13-004359_235x106_scrot

I'm choosing to go with the original horizontal-only layout
@rubiefawn rubiefawn added the needs testing This pull request needs more testing label Jun 13, 2025
@rubiefawn rubiefawn added needs code review A functional code review is currently required for this PR and removed needs testing This pull request needs more testing labels Jun 13, 2025
@rubiefawn rubiefawn requested review from messmerd and sakertooth June 13, 2025 19:22
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The effect looks fine, did a quick test, had some minor concerns but nothing really substantial.

@rubiefawn
Copy link
Contributor Author

While fixing the missing tr() calls I noticed "octaves" was also missing that. Fixed all of them 👍

Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me code-wise

@rubiefawn rubiefawn merged commit 2806a31 into LMMS:master Jun 16, 2025
11 checks passed
@rubiefawn rubiefawn deleted the feat/dispersion-svg branch June 16, 2025 02:24
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request Jun 28, 2025
@rubiefawn rubiefawn removed the needs code review A functional code review is currently required for this PR label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants