Fix old projects loading clips with auto-resize disabled #7874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll test for good measure, but since this was found by accident, that was practically a test, LOL! |
Member
|
Tested! |
bratpeki
approved these changes
May 4, 2025
sakertooth
approved these changes
May 4, 2025
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this pull request
Jun 1, 2025
A follow up to LMMS#7477, which ensures clips have auto-resizing enabled by default. This is needed because auto-resizing was the default behavior, but the code tried to use this newly added attribute with a default of 0 (i.e., auto resizing is not enabled).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7477, I forgot that clips in old projects are not saved with an "autoresize" attribute, so when loading them, it defaults to 0. However, this causes old clips in projects to be loaded without auto-resize which is not the normal behavior.
This PR fixes this by setting the default value when accessing the attribute to be 1.