-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add clip content shifting #7894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Sorry by the way. cutting.of.the.grid.movI just cutted It by default with the mouse and then used ctrl to cutt off grid and then I tested draggin with the pencil with alt then as I was writting this review I had to deliberate test It and It cutted off the grid. Anyway I tested the draggin the contents of the clip with My gosh. |
|
I need help with the shift resizing bc I reziced the clip with shift and withou It and I don't see the trick |
Actually, I think it did, just relative to the end of the clip. You can hold down the knife and drag it around to see where the cuts lines snap to. It will either snap to the global grid, relative to the start, or relative to the end.
I might have worded the description badly. Basically in normal lmms, shift resizing snaps to the grid, and normal resizing quantizes the resize amount. But this PR combines shift resizing with normal resizing, so there shouldn't be a difference. |
|
(First of all thank you @regulus79 for your work on the splitting midi clips, especially the non-destructable part. I didn't know how much I needed that until I tried it, thank you) Now, I like the content shifting idea, but I see two problems: Combined snapping for moving clips is terrible idea. Imagine I carefully placed a sample close to a grid line. Then I zoom out, do some work and then want to move it 4 bars ahead. It will be really hard to see what it snaps to. This should at least be configurable, like in piano roll where you have an nudge/snap option. Nudge should always be the default. As firiox demonstrated it's really hard to wrap your head around the logic when the options are combined. Second issue is that nobody would ever know about this cool feature. Pressing a modifier is such an obscure thing. I see the source code is cluttered with modifier actions, that nobody except the people who designed them would know about. We need to stop adding these. Modifiers should be intuitive and consistent, like snap on/off, select or zoom. To make this feature more discoverable it could be something like a handle that appeared on top of the waveform when the track height is big enough (you'll probably not use it unless you are zoomed in a little). And with that you wouldn't need to mess with combined snapping either. |


This PR adds the ability for users to shift the contents of clips without changing the clip bounds. This is useful when working with vocal samples, and you want to chop them up and arrange them without having to manually resize and move the clip each time.
To use, hold
Shiftwhile dragging on a clip. For quantized movement, holdAltorCtrlat the same time.2025-05-15.23-03-51.mp4
Note! Previously,
Shiftallowed users to drag clips while snapping their position to the global grid, while normal dragging would move them a quantized offset with respect to their current positions. This PR integrates that functionality into normal dragging, much like how #7477 integrated theShiftkey for quantized knife position from to normal knife functionality.Previously
Now
Alt or Ctrl+Shiftmoves quantized.Additionally, I similarly combined
Shiftresizing into normal resizing, since it makes things much easier for beginners, and to make things more consistent.