Skip to content

Real time safe recording with ring buffer stage one #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steven-jaro wants to merge 27 commits into
base: feature/recording-stage-one
Choose a base branch
from
Open

Real time safe recording with ring buffer stage one #7903

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5a9c811
Ring buffer for recording first implementation
steven-jaro May 23, 2025
c6f8047
Fixed ring buffer implementation approach to make it more stable and …
steven-jaro May 25, 2025
2fc50ec
Better approach for no audio saturation, code optimization, no segfau…
steven-jaro May 25, 2025
2c43aa8
Removed resize and reserve from any real time context
steven-jaro May 29, 2025
aa33e45
Fixed spaces instead of tabs size 4 and Johannes requests
steven-jaro May 30, 2025
8541272
Changed DEFAULT_BUFFER_SIZE to 100
steven-jaro May 30, 2025
dad148e
Update src/core/AudioEngine.cpp
steven-jaro May 31, 2025
e6c1097
Update include/AudioEngine.h
steven-jaro May 31, 2025
e25a58e
Update src/core/AudioEngine.cpp
steven-jaro May 31, 2025
bb00189
Update src/core/AudioEngine.cpp
steven-jaro May 31, 2025
264d15b
Update src/core/AudioEngine.cpp
steven-jaro May 31, 2025
3d02d41
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
6b4d07d
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
69734f9
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
1dae270
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
d9a22b2
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
cae9d61
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
00ab49d
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
d6cbe34
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
ed4ecb8
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
2047da5
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
11432b1
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
5820a43
Update src/core/AudioEngine.cpp
steven-jaro Jun 1, 2025
52868fd
Fixed unsafe substraction in processBufferedInputFrames
steven-jaro Jun 2, 2025
89f6521
Fixed szeli1 Requested changes includir refator
steven-jaro Dec 4, 2025
45cdb83
Update src/core/AudioEngine.cpp
steven-jaro Dec 9, 2025
95bbfd6
Update src/core/AudioEngine.cpp
steven-jaro Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/core/AudioEngine.cpp 
Co-authored-by: szeli1 <143485814+szeli1@users.noreply.github.com>
  • Loading branch information
@steven-jaro @szeli1
steven-jaro and szeli1 committed Nov 23, 2025
commit 69734f9bd6f953acb036356102d1fb8e1c7442e9
2 changes: 1 addition & 1 deletion src/core/AudioEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ void AudioEngine::renderStageNoteSetup()
removedFromPlayHandles = true;
}

if(removedFromPlayHandles)
if (removedFromPlayHandles)
{
it_rem = m_playHandlesToRemove.erase(it_rem);
}
Expand Down