Remove Knob::setHtmlLabel

[michaelgregorius]

Remove the unused method Knob::setHtmlLabel and its associated members. This removes some unnecessary complexity from the code.

[messmerd]

Could you also move Knob::setLabel back to the public section and fix KnobControl::setText?

And if you want, you could make KnobControl default constructible again by adding a default argument to the constructor:

-KnobControl(const QString& text, QWidget* parent = nullptr);
+KnobControl(const QString& text = QString{}, QWidget* parent = nullptr);

Better to do it all together than create another PR for that, I think

[michaelgregorius]

Could you also move Knob::setLabel back to the public section

Done with commit 3377bdb.

and fix KnobControl::setText?

Done with commit 82d7773.

And if you want, you could make KnobControl default constructible again by adding a default argument to the constructor:

I decided against doing so because it seems that a default constructed KnobControl would not make much sense in the context of its current usages. It would be a knob without a label that has its own window. All instances are currently only used as children of other widgets. So in most cases the parent would have to be provided explicitly anyway and due to the position in the constructor the text would have to be provided as well.

[messmerd]

LGTM