[detach-window] Wrap detached widget into a container #8091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap widget being detached into a container to handle close events correctly without relying on inheritance. Makes it possible to add additional widgets (for example separate button to attach the window back)
These are no longer needed, as the functionality is implemented in DetachedWindow and does not require inheritance. This is a mechanical check to remove files, rudimentary functionality may still be present.
Contributor
Author
|
Probably best to wait before merging, I might have a simpler solution edit: added competing PR to the post. |
6 tasks
Contributor
Author
|
Closing this in favor of #8096. Can reopen if there's any reason for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This competes with #8096.
Make a container to wrap the widget while detached that mirrors functionality of
SubWindowto a certain degree. Eliminates the need forDetachable{Widget,Window}classes since we no longer need to rely on inheritance.Questionable design decisions:
DetachedWindowonce and hiding it, it's constructed each time a window is detached and destroyed once the window is attached back. This makes them slightly easier to manage.DetachedWindowdoesn't storeSubWindowpointer in a variable, instead doingdynamic_cast<SubWindow&><*parentWidget()>, making it dependant on keeping the parent the same.DetachedWindowbeing basically dependant on SubWindow to exist, it's still kept as a pointer rather than being attached to the class. This is mostly to keep the syntax consistent.If any of these are undesirable, I can try to change them.
TODO:
Prevent detached windows attaching out-of-boundsSubject for a different PR