Some SD card init fixes.#10
Open
profi200 wants to merge 13 commits into
Open
Conversation
…iny bit of power in 4-bit mode.
Author
|
|
Reduces SD mount retries to 3 times.
Gericom
reviewed
May 3, 2026
Gericom
reviewed
May 3, 2026
Gericom
reviewed
May 3, 2026
Gericom
reviewed
May 3, 2026
Gericom
reviewed
May 3, 2026
Added OCR and ACMD42 defines.
Author
|
Should i also include this change? diff --git a/src/main.cpp b/src/main.cpp
index ae41135..6947b79 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -208,9 +208,9 @@ static inline void earlyGpioInit(void)
gpio_disable_pulls(SDIO_D3);
#endif
- gpio_pull_down(PIN_RST);
- gpio_pull_up(PIN_CEB);
- gpio_pull_up(PIN_WREB);
+ gpio_disable_pulls(PIN_RST);
+ gpio_disable_pulls(PIN_CEB);
+ gpio_disable_pulls(PIN_WREB);
gpio_disable_pulls(PIN_D0);
gpio_disable_pulls(PIN_D1);
gpio_disable_pulls(PIN_D2);
@@ -219,7 +219,7 @@ static inline void earlyGpioInit(void)
gpio_disable_pulls(PIN_D5);
gpio_disable_pulls(PIN_D6);
gpio_disable_pulls(PIN_D7);
- gpio_pull_up(PIN_CS2);
+ gpio_disable_pulls(PIN_CS2);
// Set SDIO and NTRCARD DAT pin slew rate.
// Default slew rate after reset is slow. Good enough for 25 MHz.Actually i just did because why not if i'm in there already? That change was tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally this:
What's not fixed is clock glitches on command response timeouts. This is due to restarting the state machine while it's clocking the SD.