-
Notifications
You must be signed in to change notification settings - Fork 8
Issue/238/reorganize #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/238/reorganize #250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 2165 2147 -18
=========================================
- Hits 2165 2147 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Ok, I think this is ready now, I will have to make separate PRs for rail_bpz and rail_delight after this is approved, as the move will break a couple of default config file location conventions in those repos I believe. A thing to check for reviewers: after you pip install RAIL, check the site-packages directory where the files are copied and make sure that examples, tests, etc... directories are not copied there outside of the RAIL package. This works correctly for me, but outside confirmation is always good. |
eacharles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed it with pip install . and pip install -e ., ran unit tests, both worked. Made sure the installed files end up in the right place. Ran notebooks using the documentation scripts. everything looked good.
Leaving as a draft for now, I think this is mostly done, but I need to make sure I don't have duplicate copies of files and such. This PR addresses several interrelated issues, namely
#238 (package_data files are now moved to
src/rail/examples/rather than top-levelexamples/)#245 (I eliminated the various install options, base, all, etc..., so we how just have the one standard install)
#244 (already partially fixed by addition of RAILDIR, but going through and checking default file locations for GridSelection and SpecSelection to use RAILDIR and new file locations for defaults). BPZ and Delight changes will need to be made in rail_bpz and rail_delight separate from this PR.
For #245, in eliminating the other install options, I added sklearn and pzflow to the overall package requirements. As pzflow is also used by one of the estimators, and sklearn is pretty standard, this seems uncontroversial to me, but mentioning it here just in case.
Will assign reviewers once I finish file location checks and run this on a fresh install on my other computer.