Create setup cache class and create the datatable cache class #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
tabacitu
reviewed
Jun 6, 2025
Member
tabacitu
left a comment
tabacitu
left a comment
There was a problem hiding this comment.
Niiiice! Something irks my spidey sense a bit here, so I want to take another look at this on Monday with a fresh brain.
[ci skip] [skip ci]
…-Backpack/CRUD into create-setup-cache-class
tabacitu
approved these changes
Jun 9, 2025
Member
tabacitu
left a comment
tabacitu
left a comment
There was a problem hiding this comment.
We. Are. DONE!!
RUN WITH IT, PEDRO! Merge it!
Member
There was a problem hiding this comment.
Gold. We're done here. In this file I mean.
Member
There was a problem hiding this comment.
This is very clean. And well-named. I like it. We're done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a general CacheSetup class, that can be used by any entities that need to store some kind of setupClosure in the cache.
At the moment I've created the DatatableCache that stores the setup of the datatable in the cache.