Skip to content

Conversation

@javedbaloch4
Copy link
Contributor

WHY

This PR fixes a small typo in the config/backpack/base.php file by removing a duplicated word ("the the") from a comment:

BEFORE - What was wrong? What was happening before this PR?

"... all the the middleware listed below ..."

AFTER - What is happening after this PR?

"... all the middleware listed below ..."

@welcome
Copy link

welcome bot commented Jul 2, 2025

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

  • if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
  • even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
  • not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
  • we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

--
Justin Case
The Backpack Robot

@pxpm
Copy link
Contributor

pxpm commented Jul 2, 2025

Thanks @javedbaloch4 🙏

@pxpm pxpm merged commit 20fc419 into Laravel-Backpack:main Jul 2, 2025
2 checks passed
@welcome
Copy link

welcome bot commented Jul 2, 2025

WHOOP-WHOOP! Congrats, your first PR on this repo has officially been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, committed community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

  • give your opinion on other GitHub Issues & PRs;
  • chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
  • answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-)
Cheers!

--
Justin Case
The Backpack Robot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants