-
Notifications
You must be signed in to change notification settings - Fork 8
v2 - refactor, fix bugs and support Backpack v7 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * refactor, add tests * wip * wip * update easy mde uploader * wip * remove deleted trait * wip * add repeatable trait * make functions public * rename get function * refactoring dropzone uploader * wip * add media test models * fix test models * fix media pivot namespace * fix test model namespace * add fk to relation * add media library tests * save the object in the macro * Update composer.json --------- Co-authored-by: Cristian Tăbăcitu <[email protected]>
tabacitu
commented
Nov 7, 2024
2 tasks
Member
Author
|
@pxpm please help take this branch to a clean state:
|
2 tasks
tabacitu
commented
Nov 19, 2025
9 tasks
Co-authored-by: tabacitu <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]>
tabacitu
commented
Nov 19, 2025
tabacitu
commented
Nov 19, 2025
Member
Author
|
@copilot what does this PR do? What does it add or remove in terms of functionality? What does it change? Please provide a summary of what's different in this PR, because it's supposed to be a new version of this package and we want to let our users know what's different. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Package was on v1.x supporting older PHP/Laravel/Backpack versions without comprehensive test coverage.
AFTER - What is happening after this PR?
v2.0 with modernized dependencies, automated testing, and improved API surface for extensibility.
HOW
How did you achieve that, in technical terms?
Foundation (PR #34):
API improvements:
hasDeletedFiles(),shouldUploadFiles(),getEntryAttributeValue()) for extensibilityprocessRepeatableUploads()return type fromarraytoCollectionfor consistencyDependency updates:
{ "require": { "backpack/crud": "^7.0", // was ^6.x "spatie/laravel-medialibrary": "^10.7||^11.3" }, "require-dev": { "phpunit/phpunit": "^11.0", // was ^10.0|^11.0 "orchestra/testbench": "^10.0", // was ^8.0|^9.0|^10.0 "spatie/laravel-translatable": "^6.0" // new } }CI/CD:
Is it a breaking change or non-breaking change?
Breaking changes:
processRepeatableUploads()returnsCollectioninstead ofarrayHow can we test the before & after?
Run test suite:
composer testTests cover media uploads, collections, conversions, and repeatable fields across different uploader types.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
The
nextbranch is where we bring together all fixes&features for our next version. This PR is here to document all PRs merged, all breaking changes, all remaining TODOs about this version until launch.Features
??? made it work?!
Fixes
Breaking changes
Todos
Things to do before we merge this PR into
main:composer.jsonrequirements to new version