Skip to content

Fix: Themes preset editing and persistence and display of theme item values #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LargeModGames merged 7 commits into from
May 3, 2026
Merged

Fix: Themes preset editing and persistence and display of theme item values #232

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
50390d6
Enable the change of theme item colours in the UI with immediate effect
Moaht Apr 29, 2026
3f661c5
Add Custom preset to handle user edits to presets and persist them, c…
Moaht Apr 29, 2026
07ffb21
Update the theme values in real time when cycling through the presets
Moaht Apr 29, 2026
f04462e
Run rustfmt to adjust formatting
Moaht Apr 29, 2026
b972a97
Add all theme colour options to the UI in settings > themes and enabl…
Moaht Apr 29, 2026
64890de
Add config backwards compatibility check for theme loading after upgrade
Moaht Apr 29, 2026
54f755f
Run rustfmt to adjust formatting
Moaht Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run rustfmt to adjust formatting
  • Loading branch information
@Moaht
Moaht committed Apr 29, 2026
commit 54f755f99dfc42bba3471b9a7d92ef74b6932f42
16 changes: 8 additions & 8 deletions src/core/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3742,8 +3742,8 @@ impl App {
"theme.error_border" if self.user_config.current_preset == ThemePreset::Custom => {
if let SettingValue::Color(v) = &setting.value {
if let Ok(c) = parse_theme_item(v) {
self.user_config.theme.error_border= c;
self.user_config.custom_theme.error_border= c;
self.user_config.theme.error_border = c;
self.user_config.custom_theme.error_border = c;
}
}
}
Expand Down Expand Up @@ -3774,8 +3774,8 @@ impl App {
"theme.playbar_text" if self.user_config.current_preset == ThemePreset::Custom => {
if let SettingValue::Color(v) = &setting.value {
if let Ok(c) = parse_theme_item(v) {
self.user_config.theme.playbar_text= c;
self.user_config.custom_theme.playbar_text= c;
self.user_config.theme.playbar_text = c;
self.user_config.custom_theme.playbar_text = c;
}
}
}
Expand All @@ -3790,16 +3790,16 @@ impl App {
"theme.background" if self.user_config.current_preset == ThemePreset::Custom => {
if let SettingValue::Color(v) = &setting.value {
if let Ok(c) = parse_theme_item(v) {
self.user_config.theme.background= c;
self.user_config.custom_theme.background= c;
self.user_config.theme.background = c;
self.user_config.custom_theme.background = c;
}
}
}
"theme.header" if self.user_config.current_preset == ThemePreset::Custom => {
if let SettingValue::Color(v) = &setting.value {
if let Ok(c) = parse_theme_item(v) {
self.user_config.theme.header= c;
self.user_config.custom_theme.header= c;
self.user_config.theme.header = c;
self.user_config.custom_theme.header = c;
}
}
}
Expand Down
Loading