refactor: split runtime out of main.rs and fix native playback metadata (#218)#237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to modularize runtime and playback integration logic, improves the handling of native streaming metadata freshness, and updates module paths after the runtime split. It also centralizes playback metadata extraction for integrations and adds thorough tests for playback snapshotting and metadata authority. The most important changes are as follows:
Native streaming metadata freshness and playback integration
src/infra/network/playback.rs,src/infra/media_metadata.rs). [1] [2] [3] [4] [5] [6]src/infra/media_metadata.rs). [1] [2]Runtime and module refactoring
main.rsinto focusedcore,infra, andtuimodules, moving authentication, runtime startup, TUI runner, native player event handling, and playback metadata extraction to their respective modules. Updated imports and module paths throughout the codebase to reflect this structure (src/core/mod.rs,src/infra/mod.rs,src/core/app.rs,src/core/user_config.rs,src/cli/util.rs,src/infra/player/mod.rs). [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing and internal improvements
src/infra/media_metadata.rs,src/infra/network/playback.rs). [1] [2] [3]src/core/app.rs,src/core/user_config.rs,src/cli/util.rs). [1] [2] [3] [4] [5] [6]Please let me know if you have questions about how the new playback metadata authority logic works or how to use the new module structure!