Fix UI freeze#239
Merged
Merged
Conversation
Instead of taking app lock before API fetch, taking it after fixes the issue
Replaced sequential N+1 API calls with future::join_all to execute track requests concurrently, dropping latency from appprox 10s to approx 4s
Contributor
Author
|
Apologies for the CI trip-up... I split the work into atomic commits for easier review and accidentally dropped the changes made by |
Owner
|
@all-contributors add @rlpratyoosh for code, bug |
Contributor
|
I've put up a pull request to add @rlpratyoosh! 🎉 |
LargeModGames
added a commit
that referenced
this pull request
May 9, 2026
Adds @rlpratyoosh as a contributor for code, bug. This was requested by LargeModGames [in this comment](#239 (comment)) [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #238
tracksendpoint was reducing the latency from 10s to 2s. But since it was deprecated, I usedfuture::join_all()to fetch tracks concurrently, reducing the 10s* latency to approx 4s.Testing
cargo fmt --all cargo clippy --locked -- -D warnings cargo test --locked