[WIP] Update subagent restrictions based on PR feedback #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
kcrommett
merged commit c2ed115
into
revert-pr-4773-subagent-restrictions
5 checks passed
Copilot stopped work on behalf of
kcrommett due to an error
December 10, 2025 08:34
kcrommett
added a commit
that referenced
this pull request
Dec 10, 2025
* revert: remove PR sst#4773 subagent restrictions feature This feature is not going to be merged upstream in its current form. Removes: - subagents field from Agent schema and built-in agents - subagents config option - filterSubagents function and runtime validation - Subagent filtering from prompt tool resolution - Subagent filtering from TUI autocomplete - subagents-filter.test.ts test file - Subagents documentation section from agents.mdx The SDK types will be regenerated automatically on the next build. * chore: format code * docs: update fork README to remove PR sst#4773 and refresh date * feat: add ghostty-opentui dependency for terminal ANSI rendering * feat: force color output in bash tool for ANSI rendering * feat: add live token tracking during streaming responses * fix: use correct subagent session ID for click navigation * feat: add search, token display, and bash ANSI viewer to TUI - Add Ctrl+F search with match highlighting and navigation - Add toggle tokens command with IN/OUT display - Add full-screen bash output viewer with ANSI color support - Integrate ghostty-terminal component for terminal rendering * docs: add implementation plans for restored PR features * ci: retry tests * [WIP] Update subagent restrictions based on PR feedback (#106) * Initial plan * fix: replace strikethrough with ANSI highlighting for search results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Completed
Fixed the incorrect use of strikethrough syntax for search result highlighting.
Changes Made:
~~text~~) with ANSI escape codesTechnical Details:
The previous implementation incorrectly used
~~$1~~which rendered as strikethrough text. The new implementation uses ANSI escape codes\x1b[43m\x1b[30m$1\x1b[0mwhich provides proper visual highlighting compatible with the existing terminal rendering infrastructure (ghostty-terminal component).Security Summary:
No vulnerabilities detected. CodeQL analysis found 0 alerts.
Commit: b50efdd
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.