Skip to content

fix to get around Illegal invocation error in chrome #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2015
Merged

fix to get around Illegal invocation error in chrome #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix to get around Illegal invocation error in chrome
  • Loading branch information
@zbyte64
zbyte64 committed Jun 11, 2015
commit 877c47c6f4c2c8b1788e823e82a391a2331fdc80
7 changes: 6 additions & 1 deletion src/react-fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import React from 'react/addons'
import fetch from 'isomorphic-fetch'

//this is to hack around a bug, see:
//https://github.com/matthew-andrews/isomorphic-fetch/pull/20
//import fetch from 'isomorphic-fetch'
import fetch_ from 'isomorphic-fetch';
var fetch = fetch_.bind(undefined);
Copy link

@khtdr khtdr Jun 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lines 2-6 can simply be replaced with:

import 'isomorphic-fetch'

(don't import anything into the scope, use the global fetch after importing)


export default class Fetch extends React.Component{

Expand Down