Skip to content

feat: modify withdrawBatch to account for slippage #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: modify withdrawBatch to account for slippage #83

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d3bd1b
feat: modify withdrawBatch to account for slippage
Glitch18 Jul 7, 2025
e68419b
feat: correct remainingAmount calculation to avoid underflow
Glitch18 Jul 8, 2025
1c3d1f0
fix: remaining amount calculation in withdraw batch
Glitch18 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/v2/common/libraries/VaultLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,23 +145,30 @@ library VaultLib {
uint256 strategyBalance;
uint256 remainingAmount = amount;
withdrawn = 0;
uint256 i = 0;

for (uint256 i; i < strategies.length; i++) {
while (i < strategies.length && remainingAmount > 0) {
StrategyConfig memory config = strategies[i];

strategyBalance = StrategyLib.getAssets(config, address(vault));

if (strategyBalance == 0) {
i++;
continue;
}
if (remainingAmount > strategyBalance) {
withdrawn += _withdraw(vault, config, strategyBalance);
remainingAmount -= strategyBalance;
} else {
withdrawn += _withdraw(vault, config, remainingAmount);
}

break;
if (withdrawn > amount) {
remainingAmount = 0;
} else {
remainingAmount = amount - withdrawn;
}

i++;
}

return withdrawn;
Expand Down