Skip to content

add non-None check for torch.utils.collect_env.get_pip_packages outputs#2124

Merged
lantiga merged 1 commit intomainfrom
check-get-pip-packages-output
May 30, 2025
Merged

add non-None check for torch.utils.collect_env.get_pip_packages outputs#2124
lantiga merged 1 commit intomainfrom
check-get-pip-packages-output

Conversation

@crcrpar
Copy link
Copy Markdown
Collaborator

@crcrpar crcrpar commented May 23, 2025

What does this PR do?

Fixes #2123.

as they could return `None` instead of `str`

Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar crcrpar marked this pull request as ready for review May 23, 2025 08:46
@crcrpar crcrpar requested review from lantiga, mruberry and t-vi as code owners May 23, 2025 08:46
@lantiga lantiga merged commit 6a4866a into main May 30, 2025
52 checks passed
@lantiga lantiga deleted the check-get-pip-packages-output branch May 30, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better to check get_pip_packages return values in thunder.dynamo.utils.get_env

2 participants