Remove qualified access to methods from autodiff#2147
Merged
Conversation
…ack qualified accesses to methods This reverts commit 094a9e7.
for more information, see https://pre-commit.ci
…to-methods-from-autodiff
t-vi
approved these changes
May 28, 2025
Collaborator
t-vi
left a comment
t-vi
left a comment
There was a problem hiding this comment.
Thank you @riccardofelluga
Collaborator
|
@riccardofelluga - Please edit the description of this PR that says: "Needs PR 2143 before merging." |
KaelanDt
pushed a commit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Under request from comment #2143 (review), this PR separates typing update from the other PR.
This PR removes the use of qualified accesses to methods to conform to the rest of Thunder codebase. As per the other
TraceSubstitutionProcessors the autodiff should follow the same style