TE: update test to be more stable#2156
Merged
kshitij12345 merged 1 commit intoLightning-AI:mainfrom Jun 1, 2025
Merged
Conversation
t-vi
approved these changes
Jun 1, 2025
Collaborator
t-vi
left a comment
There was a problem hiding this comment.
Looks good to me, but let's have @IvanYashchuk take a look if he wants.
IvanYashchuk
approved these changes
Jun 1, 2025
Collaborator
IvanYashchuk
left a comment
There was a problem hiding this comment.
How does the testing time change with the new target_value?
Collaborator
Author
|
On H100 Running - Main Branch - ~12.3 seconds Running 200 items in this shard
thunder/tests/test_transformer_engine_executor.py ........................................................................................................................................................................................................ [100%]
======================================================================================================================== 200 passed, 2000 deselected, 1200 warnings in 12.30s =========================================================================================================================PR Branch - ~11.3 seconds Shouldn't be very different for B200. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
pytest thunder/tests/test_transformer_engine_executor.py -k test_te_linear_forward_backward_multiple_iteration[defau --count 200(or testing withmxfp8_e4m3recipe).Could lead to
This was most likely due to not correctly initializing the linear and using dummy data. Have updated the test to initialize the Linear and also updated the target tensor for training.
Now running
pytest thunder/tests/test_transformer_engine_executor.py -k test_te_linear_forward_backward_multiple_iteration[defau --count 200passes for all cases. Tested on both H100 and B200 where default recipe is DelayedScaling and MXFP8BlockScaling respectively.