Skip to content

fix cache validity issue, tighten assert#2223

Merged
t-vi merged 2 commits intomainfrom
tom/race_condition
Jun 12, 2025
Merged

fix cache validity issue, tighten assert#2223
t-vi merged 2 commits intomainfrom
tom/race_condition

Conversation

@t-vi
Copy link
Copy Markdown
Collaborator

@t-vi t-vi commented Jun 12, 2025 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • (added assert) Did you write any new necessary tests?

What does this PR do?

Add an assert to wrapper cache retreival. This is triggered during the tests before the other change, which fixes a cache consistency issue.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@t-vi t-vi requested review from lantiga and mruberry as code owners June 12, 2025 13:53
@t-vi t-vi changed the title tighten cache validity fix cache validity issue, tighten assert Jun 12, 2025
@t-vi t-vi enabled auto-merge (squash) June 12, 2025 16:16
@t-vi t-vi merged commit 050e032 into main Jun 12, 2025
49 checks passed
@t-vi t-vi deleted the tom/race_condition branch June 12, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

1 more reviewer

@lantiga lantiga lantiga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-vi @lantiga