Skip to content

bump: OS versions for CI#2249

Merged
Borda merged 1 commit intomainfrom
bump/os-versions
Jun 17, 2025
Merged

bump: OS versions for CI#2249
Borda merged 1 commit intomainfrom
bump/os-versions

Conversation

@Borda
Copy link
Copy Markdown
Collaborator

@Borda Borda commented Jun 17, 2025

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

keep track with the actually used OS in practice
also, bumping the Mac version may help to enable the install bitsandbytes latest versions

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested review from lantiga and t-vi as code owners June 17, 2025 07:32
@github-actions github-actions bot added the ci label Jun 17, 2025
@Borda Borda requested a review from Copilot June 17, 2025 07:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI matrix to use newer OS versions in GitHub Actions.

  • Bumps macOS from 14 to 15 and Windows runner from windows-2022 to windows-latest.
  • Adds Ubuntu 24.04 jobs for Python 3.11–3.13 in the include section.
Comments suppressed due to low confidence (2)

.github/workflows/ci-testing.yml:29

  • The default Ubuntu runner remains at 22.04 while you added Ubuntu 24.04 in include. If the intention is to fully bump Ubuntu, consider changing the default ubuntu-22.04 to ubuntu-24.04.
os: ["ubuntu-22.04", "macOS-15", "windows-latest"]

.github/workflows/ci-testing.yml:29

  • [nitpick] Using windows-latest can introduce variability when GitHub updates the default Windows image. For more reproducible builds, consider pinning to a specific runner like windows-2022.
os: ["ubuntu-22.04", "macOS-15", "windows-latest"]

@Borda Borda enabled auto-merge (squash) June 17, 2025 08:09
Copy link
Copy Markdown
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda

@Borda Borda merged commit 0ba1063 into main Jun 17, 2025
49 checks passed
@Borda Borda deleted the bump/os-versions branch June 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants