make masking RFC complaint and fix #208 #369
Merged
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketplus
force-pushed
the
master
branch
3 times, most recently
from
2746929 to
fa9ec66
Compare
|
build seems to be consistent with with latest commit. As in same first 3 test failures. Otherwise it looks good. Still did not get a chance to test in to device though. The end to end tests. |
|
the changes looking good, looks like Arduino has a build problem with the board. |
|
travis builds have bin fixed, some changes in the ESP8266 repo has broken them. |
|
nice, it seems to be passing now. Let me know if any other changes are required from my side @Links2004 |
|
all good, have merged the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasn't able to test. Hoping for CI to test it. Please let me know if any changes required.