style(sonar): fix cpp:S4962

[ReenigneArcher]

Description

Fixes sonar cpp:S4962 issues.

Screenshot

Issues Fixed or Closed

• Fixes https://sonarcloud.io/project/issues?rules=cpp%3AS4962&issueStatuses=OPEN%2CCONFIRMED&id=LizardByte_Sunshine

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Bundle Report

Bundle size has no change ✅

[codecov]

Codecov Report

❌ Patch coverage is 4.83871% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.36%. Comparing base (dbe80d0) to head (2232e6e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/platform/windows/misc.cpp	8.69%	21 Missing ⚠️
src/system_tray.cpp	0.00%	17 Missing ⚠️
src/nvenc/nvenc_d3d11.cpp	0.00%	4 Missing ⚠️
src/platform/windows/nvprefs/driver_settings.cpp	0.00%	4 Missing ⚠️
src/platform/windows/input.cpp	0.00%	2 Missing ⚠️
...tform/windows/nvprefs/nvapi_opensource_wrapper.cpp	0.00%	2 Missing ⚠️
src/platform/windows/nvprefs/undo_file.cpp	0.00%	2 Missing ⚠️
src/config.cpp	0.00%	1 Missing ⚠️
src/nvenc/nvenc_d3d11_on_cuda.cpp	0.00%	1 Missing ⚠️
src/nvhttp.cpp	0.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4140   +/-   ##
=======================================
  Coverage   11.36%   11.36%           
=======================================
  Files          92       92           
  Lines       17568    17568           
  Branches     8070     8070           
=======================================
  Hits         1997     1997           
  Misses      14709    14709           
  Partials      862      862           

Flag	Coverage Δ
Linux-AppImage	11.58% <0.00%> (ø)
Windows-AMD64	12.44% <4.83%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/entry_handler.cpp	1.72% <ø> (ø)
src/nvenc/nvenc_d3d11_on_cuda.h	0.00% <ø> (ø)
src/config.cpp	0.00% <0.00%> (ø)
src/nvenc/nvenc_d3d11_on_cuda.cpp	0.00% <0.00%> (ø)
src/nvhttp.cpp	18.10% <0.00%> (ø)
src/platform/windows/audio.cpp	25.32% <0.00%> (ø)
src/platform/windows/display_base.cpp	35.50% <50.00%> (ø)
src/platform/windows/display_vram.cpp	8.95% <0.00%> (ø)
src/platform/windows/nvprefs/nvprefs_common.h	0.00% <0.00%> (ø)
src/platform/windows/input.cpp	0.63% <0.00%> (ø)
... and 6 more