Log error if happens

Removed unecessary this.
Other code cleaning

src/LogExpert/Controls/LogTabWindow/LogTabWindow.cs

@@ -74,7 +74,7 @@ public LogTabWindow(string[] fileNames, int instanceNumber, bool showInstanceNum
         {
             InitializeComponent();            
 
-            ChangeTheme(this.Controls);
+            ChangeTheme(Controls);
 
             _startupFileNames = fileNames;
             this._instanceNumber = instanceNumber;
@@ -206,52 +206,52 @@ public void ChangeTheme(Control.ControlCollection container)
                         }
                         catch (Exception ex)
                         {
-                            Console.WriteLine(ex.Message);
+                            _logger.Error(ex, "An error occured while applying style dynamically to all Controls under LogTabWindow:");
                         }
                     }
                 }
             }
             #endregion
 
             // Colors for selected menus
-            this.mainMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            mainMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
 
             // Dock special color
-            this.dockPanel.DockBackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            dockPanel.DockBackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
 
             // Remove toolstrip bottom border
-            this.buttonToolStrip.Renderer = new LogExpert.Extensions.ToolStripRendererExtension();
+            buttonToolStrip.Renderer = new LogExpert.Extensions.ToolStripRendererExtension();
 
             #region Tabs
-            this.tabContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            tabContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
 
             // Tabs menu
-            for (var y = 0; y < this.tabContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < tabContextMenuStrip.Items.Count; y++)
             {
-                var item = this.tabContextMenuStrip.Items[y];
+                var item = tabContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
             // Tabs line
-            this.dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.DockStripGradient.StartColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
-            this.dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.DockStripGradient.EndColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
+            dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.DockStripGradient.StartColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
+            dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.DockStripGradient.EndColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
 
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.DockStripGradient.StartColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.DockStripGradient.EndColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.DockStripGradient.StartColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.DockStripGradient.EndColor = LogExpert.Config.ColorMode.TabsBackgroundStripColor;
 
             // Tabs
-            this.dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.StartColor = LogExpert.Config.ColorMode.ActiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.EndColor = LogExpert.Config.ColorMode.ActiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;
+            dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.StartColor = LogExpert.Config.ColorMode.ActiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.EndColor = LogExpert.Config.ColorMode.ActiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.ToolWindowGradient.ActiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;
 
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.StartColor = LogExpert.Config.ColorMode.ActiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.EndColor = LogExpert.Config.ColorMode.ActiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.StartColor = LogExpert.Config.ColorMode.ActiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.EndColor = LogExpert.Config.ColorMode.ActiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.ActiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;
 
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.StartColor = LogExpert.Config.ColorMode.InactiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.EndColor = LogExpert.Config.ColorMode.InactiveTabColor;
-            this.dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;            
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.StartColor = LogExpert.Config.ColorMode.InactiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.EndColor = LogExpert.Config.ColorMode.InactiveTabColor;
+            dockPanel.Skin.DockPaneStripSkin.DocumentGradient.InactiveTabGradient.TextColor = LogExpert.Config.ColorMode.ForeColor;            
             #endregion Tabs
         }
         #endregion

src/LogExpert/Controls/LogWindow/LogWindow.cs

@@ -244,9 +244,12 @@ public LogWindow(LogTabWindow.LogTabWindow parent, string fileName, bool isTempF
             _statusLineTrigger.Signal += OnStatusLineTriggerSignal;
             _selectionChangedTrigger.Signal += OnSelectionChangedTriggerSignal;
 
-            ChangeTheme(this.Controls);
+            ChangeTheme(Controls);
         }
 
+        #endregion
+
+        #region ColorTheme
         public void ChangeTheme(Control.ControlCollection container)
         {
             #region ApplyColorToAllControls
@@ -270,83 +273,83 @@ public void ChangeTheme(Control.ControlCollection container)
             #region DataGridView
 
             // Main DataGridView
-            this.dataGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
-            this.dataGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
-            this.dataGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
-            this.dataGridView.EnableHeadersVisualStyles = false;
+            dataGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            dataGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
+            dataGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
+            dataGridView.EnableHeadersVisualStyles = false;
 
             // Colors for menu
-            this.dataGridContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-            this.bookmarkContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-            this.columnContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-            this.editModeContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-            this.filterContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-            this.filterListContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
-
-            for (var y = 0; y < this.dataGridContextMenuStrip.Items.Count; y++)
+            dataGridContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            bookmarkContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            columnContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            editModeContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            filterContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            filterListContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+
+            for (var y = 0; y < dataGridContextMenuStrip.Items.Count; y++)
             {
-                var item = this.dataGridContextMenuStrip.Items[y];
+                var item = dataGridContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
-            for (var y = 0; y < this.bookmarkContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < bookmarkContextMenuStrip.Items.Count; y++)
             {
-                var item = this.bookmarkContextMenuStrip.Items[y];
+                var item = bookmarkContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
-            for (var y = 0; y < this.columnContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < columnContextMenuStrip.Items.Count; y++)
             {
-                var item = this.columnContextMenuStrip.Items[y];
+                var item = columnContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
-            for (var y = 0; y < this.editModeContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < editModeContextMenuStrip.Items.Count; y++)
             {
-                var item = this.editModeContextMenuStrip.Items[y];
+                var item = editModeContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
-            for (var y = 0; y < this.filterContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < filterContextMenuStrip.Items.Count; y++)
             {
-                var item = this.filterContextMenuStrip.Items[y];
+                var item = filterContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
-            for (var y = 0; y < this.filterListContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < filterListContextMenuStrip.Items.Count; y++)
             {
-                var item = this.filterListContextMenuStrip.Items[y];
+                var item = filterListContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
             // Filter dataGridView
-            this.filterGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
-            this.filterGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
-            this.filterGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
-            this.filterGridView.EnableHeadersVisualStyles = false;
+            filterGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            filterGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
+            filterGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
+            filterGridView.EnableHeadersVisualStyles = false;
 
             // Colors for menu
-            this.filterContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            filterContextMenuStrip.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
 
-            for (var y = 0; y < this.filterContextMenuStrip.Items.Count; y++)
+            for (var y = 0; y < filterContextMenuStrip.Items.Count; y++)
             {
-                var item = this.filterContextMenuStrip.Items[y];
+                var item = filterContextMenuStrip.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }
 
             #endregion DataGridView
 
-            this.proFiltersRichTextBox.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
-            this.proFiltersRichTextBox.ForeColor = LogExpert.Config.ColorMode.ForeColor;
+            proFiltersRichTextBox.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
+            proFiltersRichTextBox.ForeColor = LogExpert.Config.ColorMode.ForeColor;
 
-            this.filterComboBox.BackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            filterComboBox.BackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
         }
 
         #endregion

src/LogExpert/Controls/LogWindow/LogWindowPrivate.cs

@@ -1175,8 +1175,9 @@ private void PaintHighlightedCell(DataGridViewCellPaintingEventArgs e, DataGridV
                     }
                 }
 
-                if (foreColor == System.Drawing.Color.Black)
+                if (foreColor == System.Drawing.Color.Black) { 
                     foreColor = LogExpert.Config.ColorMode.ForeColor;
+                }
 
                 TextRenderer.DrawText(e.Graphics, matchWord, font, wordRect,
                     foreColor, flags);

src/LogExpert/Dialogs/BookmarkWindow.cs

@@ -32,9 +32,13 @@ public BookmarkWindow()
             bookmarkDataGridView.CellValueNeeded += boomarkDataGridView_CellValueNeeded;
             bookmarkDataGridView.CellPainting += boomarkDataGridView_CellPainting;
 
-            ChangeTheme(this.Controls);
+            ChangeTheme(Controls);
         }
 
+        #endregion
+
+        #region ColorTheme
+
         public void ChangeTheme(Control.ControlCollection container)
         {
             #region ApplyColorToAllControls
@@ -57,20 +61,20 @@ public void ChangeTheme(Control.ControlCollection container)
 
             #region DataGridView
 
-            this.BackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            BackColor = LogExpert.Config.ColorMode.DockBackgroundColor;
 
             // Main DataGridView
-            this.bookmarkDataGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
-            this.bookmarkDataGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
-            this.bookmarkDataGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
-            this.bookmarkDataGridView.EnableHeadersVisualStyles = false;            
+            bookmarkDataGridView.BackgroundColor = LogExpert.Config.ColorMode.DockBackgroundColor;
+            bookmarkDataGridView.ColumnHeadersDefaultCellStyle.BackColor = LogExpert.Config.ColorMode.BackgroundColor;
+            bookmarkDataGridView.ColumnHeadersDefaultCellStyle.ForeColor = LogExpert.Config.ColorMode.ForeColor;
+            bookmarkDataGridView.EnableHeadersVisualStyles = false;            
 
             // Colors for menu
-            this.contextMenuStrip1.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
+            contextMenuStrip1.Renderer = new LogExpert.Extensions.ExtendedMenuStripRenderer();
 
-            for (var y = 0; y < this.contextMenuStrip1.Items.Count; y++)
+            for (var y = 0; y < contextMenuStrip1.Items.Count; y++)
             {
-                var item = this.contextMenuStrip1.Items[y];
+                var item = contextMenuStrip1.Items[y];
                 item.ForeColor = LogExpert.Config.ColorMode.ForeColor;
                 item.BackColor = LogExpert.Config.ColorMode.MenuBackgroundColor;
             }            

src/LogExpert/Extensions/Forms/MenuStripExtension.cs

@@ -0,0 +1,40 @@
+using System;
+using System.Collections.Generic;
+using System.Drawing;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using System.Windows.Forms;
+
+namespace LogExpert.Extensions
+{
+    public class ExtendedMenuStripRenderer : ToolStripProfessionalRenderer
+    {
+        public ExtendedMenuStripRenderer() : base(new MenuSelectedColors()) { }
+    }
+
+    public class MenuSelectedColors : ProfessionalColorTable
+    {
+        public override Color ImageMarginGradientBegin => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color ImageMarginGradientMiddle => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color ImageMarginGradientEnd => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color ToolStripDropDownBackground => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color MenuBorder => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color MenuItemBorder => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color MenuItemSelected => LogExpert.Config.ColorMode.HoverMenuBackgroundColor;
+
+        public override Color MenuItemSelectedGradientBegin => LogExpert.Config.ColorMode.HoverMenuBackgroundColor;
+
+        public override Color MenuItemSelectedGradientEnd => LogExpert.Config.ColorMode.HoverMenuBackgroundColor;
+
+        public override Color MenuItemPressedGradientBegin => LogExpert.Config.ColorMode.MenuBackgroundColor;
+
+        public override Color MenuItemPressedGradientEnd => LogExpert.Config.ColorMode.MenuBackgroundColor;
+    }
+}

src/LogExpert/Extensions/ToolStripRendererExtension.cs → src/LogExpert/Extensions/Forms/ToolStripRendererExtension.cs

@@ -13,6 +13,7 @@ public ToolStripRendererExtension() { }
 
         protected override void OnRenderToolStripBorder(ToolStripRenderEventArgs e)
         {
+            // Commented on purpose to avoid drawing the border that appears visible in Dark Mode (not visible in Bright mode)
             //base.OnRenderToolStripBorder(e);
         }
     }