Skip to content

Code Clean up #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Code Clean up #257

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
08f504b
Refactor index.js
mfeniseycopes Apr 15, 2017
0e9cbee
Fix noLogger ordering
mfeniseycopes Apr 15, 2017
a32491f
Have option checkers return boolean
mfeniseycopes Apr 15, 2017
e6c039a
Add more specs/reorganize
mfeniseycopes Apr 16, 2017
ace19b8
noLogger -> hasLogger
mfeniseycopes May 19, 2017
3d5cb30
Code Clean up
Sep 8, 2017
7587ba6
Merge branch 'refactor'
Sep 8, 2017
d936f20
Fixes:
Aug 6, 2019
d8f16ac
Added in shrinkwrap and lint issues clear.
Aug 6, 2019
dd3d15f
update dependencies and cleanup
Aug 6, 2019
5512b6d
lint cleanup diff
Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Have option checkers return boolean
  • Loading branch information
@mfeniseycopes
mfeniseycopes committed May 19, 2017
commit a32491f6f9171586dd65ffaae35b0e490b9be5ed
8 changes: 4 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,19 @@ import defaults from './defaults';
* @returns {function} logger middleware
*/
function directlyApplied(options) {
return options.getState && options.dispatch;
return !!(options.getState && options.dispatch);
}

function noLogger(options) {
return typeof options.logger === 'undefined';
return !options.logger;
}

function shouldNotLog({ predicate }, getState, action) {
return typeof predicate === 'function' && !predicate(getState, action);
return !!(typeof predicate === 'function' && !predicate(getState, action));
}

function shouldDiff({ diff, diffPredicate }, getState, action) {
return diff && typeof diffPredicate === 'function' && diffPredicate(getState, action);
return !!(diff && typeof diffPredicate === 'function' && diffPredicate(getState, action));
}

function emptyLogger() {
Expand Down