Resolve #319: tapping the widget opens the app #334
Conversation
Register the "Loop" app url scheme in order to make the app an addressable target.
|
this resolves #319 - adding this comment to link the two. |
Loop/Info.plist
Outdated
| <dict> | ||
| <key>CFBundleURLSchemes</key> | ||
| <array> | ||
| <string>Loop</string> |
There was a problem hiding this comment.
Lowercase would be preferred. Any idea if this will create conflicts with another app?
Alternatively you could derive something unique using the bundle identifier, which will be nice for the few folks who have multiple installations.
There was a problem hiding this comment.
I did some searching and couldn't find a canonical repository, and since "loop" is 4 characters I'm positive there's a conflict out there somewhere. I just pushed a change to use MAIN_APP_BUNDLE_IDENTIFIER, so the URL now looks like: "com.loopkit.Loop://".
It works in the simulator. Haven't tested it on my device yet.
Loop/Extensions/NSBundle.swift
Outdated
|
|
||
| var mainAppUrl: URL? { | ||
| if let mainAppBundleIdentifier = mainAppBundleIdentifier { | ||
| return URL(string: mainAppBundleIdentifier + "://") |
There was a problem hiding this comment.
"\(mainAppBundleIdentifier)://"
* type casting to display the mock pump HUD view * define mock pump manager conformance to PumpManagerUI as soon as possible * removed unused code
3 participants
Register the "Loop" app url scheme in order to make the app an addressable target.