Charts refactor #393
Merged
Charts refactor #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ps2
commented
Mar 6, 2017
ps2
commented
- Refactoring charting code to remove unnecessary work and unnecessary caching
- userDefaults["ModifiedCarbEntries"] never cleared for non-nightscout users
- Fixing a black screen during launch animation
- Disabled Amplitude's attempted CLLocation usage
|
@bharat You should take a look at the chart changes in this PR, and let me know if you have any comments. |
|
thanks for the heads up. this looks like it's moving in the right direction for me to use StatusChartManager in Loop Status Extension without it dragging in LoopKit and friends. I haven't had a chance to review it in detail, and it looks like it's not quite there yet (because StatusChartManager still requires LoopKit) - but I think this will get us most of the way there. |
ps2
pushed a commit
that referenced
this pull request
Jun 11, 2021
- https://tidepool.atlassian.net/browse/LOOP-1274 - Move mode from view model into SettingsView - Move chart color palette from view model into environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.