Skip to content

Eventual BG for dosing decisions should be no further out than insulation action duration #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2017
Merged

Eventual BG for dosing decisions should be no further out than insulation action duration #450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48fa7ea
do not forecast out beyond dia
ps2 Apr 18, 2017
d047bc6
allow forecast to go beyond dia, but dosing decisions should only use…
ps2 Apr 21, 2017
a0567c1
Adding tests for bg rising past dia
ps2 Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow forecast to go beyond dia, but dosing decisions should only use… 
… eventual bg no further out than dia.
  • Loading branch information
@ps2
ps2 committed Apr 21, 2017
commit d047bc6c426b952303128ace904d715f0c7f7d97
12 changes: 8 additions & 4 deletions Loop/Managers/DoseMath.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,15 @@ struct DoseMath {
glucoseTargetRange: GlucoseRangeSchedule,
insulinSensitivity: InsulinSensitivitySchedule,
basalRateSchedule: BasalRateSchedule,
minimumBGGuard: GlucoseThreshold
minimumBGGuard: GlucoseThreshold,
insulinActionDuration: TimeInterval
) -> (rate: Double, duration: TimeInterval)? {
guard glucose.count > 1 else {
return nil
}

let eventualGlucose = glucose.last!
let eventualGlucose = glucose.filter { $0.startDate < date.addingTimeInterval(insulinActionDuration) }.last!

let minGlucose = glucose.min { $0.quantity < $1.quantity }!

let eventualGlucoseTargets = glucoseTargetRange.value(at: eventualGlucose.startDate)
Expand Down Expand Up @@ -151,13 +153,15 @@ struct DoseMath {
insulinSensitivity: InsulinSensitivitySchedule,
basalRateSchedule: BasalRateSchedule,
pendingInsulin: Double,
minimumBGGuard: GlucoseThreshold
minimumBGGuard: GlucoseThreshold,
insulinActionDuration: TimeInterval
) -> BolusRecommendation {
guard glucose.count > 1 else {
return BolusRecommendation(amount: 0, pendingInsulin: pendingInsulin)
}

let eventualGlucose = glucose.last!
let eventualGlucose = glucose.filter { $0.startDate < date.addingTimeInterval(insulinActionDuration) }.last!

let minGlucose = glucose.min { $0.quantity < $1.quantity }!

let eventualGlucoseTargets = glucoseTargetRange.value(at: eventualGlucose.startDate)
Expand Down
21 changes: 11 additions & 10 deletions Loop/Managers/LoopDataManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,6 @@ final class LoopDataManager {
throw LoopError.missingDataError(details: "Glucose data not available", recovery: "Check your CGM data source")
}

guard let insulinActionDuration = self.doseStore.insulinActionDuration else {
throw LoopError.configurationError("Missing insulin action duration.")
}

if glucoseChange == nil {
updateGroup.enter()
glucoseStore.getRecentGlucoseChange { (values, error) in
Expand Down Expand Up @@ -421,7 +417,7 @@ final class LoopDataManager {
self.logger.addError(error, fromSource: "CarbStore")
self.carbEffect = nil
} else {
self.carbEffect = effects.filterDateRange(effectStartDate, Date.init(timeIntervalSinceNow: insulinActionDuration))
self.carbEffect = effects
}

updateGroup.leave()
Expand Down Expand Up @@ -794,7 +790,8 @@ final class LoopDataManager {
maxBasal = settings.maximumBasalRatePerHour,
let glucoseTargetRange = settings.glucoseTargetRangeSchedule,
let insulinSensitivity = insulinSensitivitySchedule,
let basalRates = basalRateSchedule
let basalRates = basalRateSchedule,
let insulinActionDuration = insulinActionDuration
else {
error = LoopError.configurationError("Check settings")
throw error!
Expand All @@ -809,7 +806,8 @@ final class LoopDataManager {
glucoseTargetRange: glucoseTargetRange,
insulinSensitivity: insulinSensitivity,
basalRateSchedule: basalRates,
minimumBGGuard: minimumBGGuard
minimumBGGuard: minimumBGGuard,
insulinActionDuration: insulinActionDuration
)
else {
recommendedTempBasal = nil
Expand All @@ -830,7 +828,8 @@ final class LoopDataManager {
let maxBolus = settings.maximumBolus,
let glucoseTargetRange = settings.glucoseTargetRangeSchedule,
let insulinSensitivity = insulinSensitivitySchedule,
let basalRates = basalRateSchedule
let basalRates = basalRateSchedule,
let insulinActionDuration = insulinActionDuration
else {
throw LoopError.configurationError("Check Settings")
}
Expand All @@ -853,7 +852,8 @@ final class LoopDataManager {
insulinSensitivity: insulinSensitivity,
basalRateSchedule: basalRates,
pendingInsulin: pendingInsulin,
minimumBGGuard: minimumBGGuard
minimumBGGuard: minimumBGGuard,
insulinActionDuration: insulinActionDuration
)

let recommendationWithoutMomentum = DoseMath.recommendBolusFromPredictedGlucose(glucoseWithoutMomentum,
Expand All @@ -862,7 +862,8 @@ final class LoopDataManager {
insulinSensitivity: insulinSensitivity,
basalRateSchedule: basalRates,
pendingInsulin: pendingInsulin,
minimumBGGuard: minimumBGGuard
minimumBGGuard: minimumBGGuard,
insulinActionDuration: insulinActionDuration
)

if recommendationWithMomentum.amount > recommendationWithoutMomentum.amount {
Expand Down