Swiftcharts update #455
Merged
Swiftcharts update #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
pushed a commit
that referenced
this pull request
Oct 4, 2021
* LOOP-3853: Puts bolus error description into notification body if need be Turns out the issue is that the `errorDescription` from the pump manager was being put into an iOS notification's `subtitle` field, which apparently can only be one line. Thus, if it is too long, it gets ellipsized. At first I just put it into the `body`, but then I thought that this might not be in the spirit of the original implementation, so I made a conservative estimate for the max length that would fit in the subtitle. If it fits, it still puts it there. If it doesn't, it puts it into the body. * Reverts algorithm that was still trying to use subtitle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.