ocm: enhance invitation flow #1
Conversation
ishank011
left a comment
ishank011
left a comment
There was a problem hiding this comment.
Hi Hugo. A couple of comments.
|
@LovisaLugnegard can you merge into your branch? Like that your PR will be updated automatically. |
LovisaLugnegard
left a comment
LovisaLugnegard
left a comment
There was a problem hiding this comment.
Some smaller comments and thoughts.
| 400: | ||
| description: Invalid token? | ||
| description: | | ||
| Bad request due to invalid parameters, e.g. email is not valid. |
There was a problem hiding this comment.
Should probably remove "email" and maybe put "provider"?
| summary: Forward information from invite to the cloud provider. | ||
| description: Foo | ||
| summary: Accept an invititation to start sharing. | ||
| description: Accepts an invitation to the shared document so the provider can initiate the OCM share creation. |
There was a problem hiding this comment.
I think this description needs to be updated, I'm not sure exactly how though. But isn't this an invitation to be able to share with someone ie in some sense decoupled from the sharing itself, like:
- Invite A
- Now one can share with A?
There was a problem hiding this comment.
Yes, you accept the invitation to create a share with the person. Invitation and share creation are both decoupled. We can remove the shared document part.
LovisaLugnegard
merged commit 2989d9d
into
LovisaLugnegard:add-endpoint-to-accept-invite
3 participants
Closes sciencemesh/sciencemesh#22