Skip to content

Conversation

@jbogard
Copy link
Contributor

@jbogard jbogard commented Nov 16, 2018

Fixes #2628

@jbogard jbogard added this to the 8.0.0 milestone Nov 16, 2018
@jbogard jbogard requested a review from lbargaoanu November 16, 2018 15:07
Copy link
Contributor

@lbargaoanu lbargaoanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems obvious that it works by scanning all the maps, but maybe an explicit warning would be in order.

@jbogard jbogard merged commit af60a49 into master Nov 17, 2018
@jbogard jbogard deleted the simplify-include-base branch November 17, 2018 08:23
@lock
Copy link

lock bot commented May 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify inclusion of base mappings

3 participants