-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Support mapping of polymorphic collection with abstract parent type #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lbargaoanu
merged 4 commits into
LuckyPennySoftware:basic_include
from
kvpt:basic_include_abstract
Jun 16, 2023
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
src/UnitTests/Projection/ProjectAbstractWithInheritance.cs
kvpt marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| namespace AutoMapper.UnitTests.Projection; | ||
|
|
||
| public class ProjectAbstractWithInheritance : AutoMapperSpecBase | ||
| { | ||
| class StepGroup | ||
| { | ||
| public int Id { get; set; } | ||
| public string Name { get; set; } | ||
| public ICollection<Step> Steps { get; set; } = new HashSet<Step>(); | ||
| } | ||
| abstract class Step | ||
| { | ||
| public int Id { get; set; } | ||
| public string Name { get; set; } | ||
| } | ||
| class CheckingStep : Step { } | ||
| class InstructionStep : Step { } | ||
|
|
||
| class StepGroupModel | ||
| { | ||
| public int Id { get; set; } | ||
| public string Name { get; set; } | ||
| public ICollection<StepModel> Steps { get; set; } = new HashSet<StepModel>(); | ||
| } | ||
| abstract class StepModel | ||
| { | ||
| public int Id { get; set; } | ||
| public string Name { get; set; } | ||
| } | ||
| class CheckingStepModel : StepModel { } | ||
| class InstructionStepModel : StepModel { } | ||
|
|
||
| protected override MapperConfiguration CreateConfiguration() | ||
| { | ||
| return new MapperConfiguration(cfg => | ||
| { | ||
| cfg.CreateMap<StepGroup, StepGroupModel>(); | ||
| cfg.CreateMap<Step, StepModel>(); | ||
| cfg.CreateMap<CheckingStep, CheckingStepModel>() | ||
| .IncludeBase<Step, StepModel>(); | ||
| cfg.CreateMap<InstructionStep, InstructionStepModel>() | ||
| .IncludeBase<Step, StepModel>(); | ||
| }); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void ProjectCollectionWithElementInheritingAbstractClassWithoutException() | ||
| { | ||
| var stepGroup = new StepGroup | ||
| { | ||
| Id = 1, | ||
| Name = "StepGroup", | ||
| Steps = new List<Step> | ||
| { | ||
| new InstructionStep | ||
| { | ||
| Id = 1, | ||
| Name = "InstructionStep" | ||
| }, | ||
| new CheckingStep | ||
| { | ||
| Id = 2, | ||
| Name = "CheckingStep" | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| var query = new[] { stepGroup }.AsQueryable(); | ||
|
|
||
| Should.NotThrow(() => query.ProjectTo<StepGroupModel>(Configuration).SingleOrDefault()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better fix is to simply skip abstract types when computing polymorphic maps.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with that, or perhaps I don't see how to do it this way at this level.
Because the abstract type mapping don't come from the polymorphic map but from the EnumerableProjectionMapper.Project method.
This is because it is this abstract type that is used for the collection property in the entity.
I don't see how I can filter it before this moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess both make sense, projecting to an abstract type when there are included maps and also including an abstract map, presumably for configuration reuse.