Skip to content

Constructor mapping inheritance #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbargaoanu merged 6 commits into from
Jul 3, 2023
Merged

Constructor mapping inheritance #4314

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3fcd6a
Initial attempt to solve constructor mappings inheritance
rubengonzalezlodeiro Jun 26, 2023
7cb8580
Fix test
rubengonzalezlodeiro Jun 27, 2023
4473bf5
Changed implementation to be more like ApplyIncludedMember
rubengonzalezlodeiro Jul 1, 2023
75a5958
More PR feedback plus solving mapping not really working
rubengonzalezlodeiro Jul 2, 2023
6792e53
CanConstruct.ShouldBeFalse()
lbargaoanu Jul 3, 2023
d5edfd1
cosmetic
lbargaoanu Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cosmetic
  • Loading branch information
@lbargaoanu
lbargaoanu committed Jul 3, 2023
commit d5edfd11f3e4a11a63e55ddb8adcd5abdd667c99
9 changes: 3 additions & 6 deletions src/AutoMapper/ConstructorMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,11 @@ public ConstructorParameterMap(TypeMap typeMap, ParameterInfo parameter, MemberI
SourceMembers = Array.Empty<MemberInfo>();
}
}
public ConstructorParameterMap(ConstructorParameterMap parameterMap, IncludedMember includedMember) :
this(includedMember.TypeMap, parameterMap.Parameter, parameterMap.SourceMembers) =>
public ConstructorParameterMap(ConstructorParameterMap parameterMap, IncludedMember includedMember) : this(includedMember.TypeMap, parameterMap) =>
IncludedMember = includedMember.Chain(parameterMap.IncludedMember);
public ConstructorParameterMap(TypeMap typeMap, ConstructorParameterMap inheritedParameterMap) : base(typeMap)
{
Parameter = inheritedParameterMap.Parameter;
public ConstructorParameterMap(TypeMap typeMap, ConstructorParameterMap inheritedParameterMap) :
this(typeMap, inheritedParameterMap.Parameter, inheritedParameterMap.SourceMembers) =>
Resolver = inheritedParameterMap.Resolver;
}
public ParameterInfo Parameter { get; }
public override Type DestinationType => Parameter.ParameterType;
public override IncludedMember IncludedMember { get; }
Expand Down