Simplify CheckLicense to use GetRequiredService instead of fallback l…

…ogic

Co-authored-by: jbogard <104498+jbogard@users.noreply.github.com>

src/MediatR/MicrosoftExtensionsDI/MediatRServiceCollectionExtensions.cs

@@ -62,12 +62,8 @@ internal static void CheckLicense(this IServiceProvider serviceProvider)
     {
         if (LicenseChecked == false)
         {
-            var licenseAccessor = serviceProvider.GetService<LicenseAccessor>() ?? new LicenseAccessor(
-                serviceProvider.GetRequiredService<MediatRServiceConfiguration>(),
-                serviceProvider.GetRequiredService<ILoggerFactory>()
-            );
-            var licenseValidator = serviceProvider.GetService<LicenseValidator>()
-                                   ?? new LicenseValidator(serviceProvider.GetRequiredService<ILoggerFactory>());
+            var licenseAccessor = serviceProvider.GetRequiredService<LicenseAccessor>();
+            var licenseValidator = serviceProvider.GetRequiredService<LicenseValidator>();
 
             var license = licenseAccessor.Current;
             licenseValidator.Validate(license);

test/MediatR.Tests/ServiceFactoryTests.cs

@@ -51,7 +51,10 @@ public void Should_not_throw_with_manual_registration()
         var services = new ServiceCollection();
         services.AddFakeLogging();
         services.AddTransient<IMediator, Mediator>();
-        services.AddSingleton(new MediatRServiceConfiguration());
+        var config = new MediatRServiceConfiguration();
+        services.AddSingleton(config);
+        services.AddSingleton<LicenseAccessor>();
+        services.AddSingleton<LicenseValidator>();
 
         var container = services.BuildServiceProvider();