Skip to content

Fix "The Castle Windsor Implementation doesn't work with exception handlers #741" issue #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbogard merged 4 commits into from
May 18, 2022
Merged

Fix "The Castle Windsor Implementation doesn't work with exception handlers #741" issue #742

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a251d0
Fix MediatR examples exception handlers
alexandruchirita4192 May 17, 2022
7a1525b
Fix MediatR examples exception handlers overrides
alexandruchirita4192 May 17, 2022
add1900
Explain some important code in examples
alexandruchirita4192 May 17, 2022
19211b3
Castle Windsor test streams too and fix all checks
alexandruchirita4192 May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explain some important code in examples
  • Loading branch information
@alexandruchirita4192
alexandruchirita4192 authored May 17, 2022
commit add1900451ed10734c17e66bd6e43d648d3dd098
4 changes: 3 additions & 1 deletion samples/MediatR.Examples/Runner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,9 @@ private static bool IsExceptionHandledBy<TException, THandler>(WrappingWriter wr
{
var messages = writer.Contents.Split(new[] { "\r\n", "\r", "\n" }, StringSplitOptions.None).ToList();

// Note: For this handler type to be found in messages, it must be written in all tested exception handlers
return messages[messages.Count - 2].Contains(typeof(THandler).FullName)
// Note: For this exception type to be found in messages, exception must be written in all tested exception handlers
&& messages[messages.Count - 3].Contains(typeof(TException).FullName);
}
}
Expand Down Expand Up @@ -336,4 +338,4 @@ public override Task WriteLineAsync(string value)
public override Encoding Encoding => _innerWriter.Encoding;

public string Contents => _stringWriter.ToString();
}
}