fix: use web component for workflow config #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
MCMic
approved these changes
Sep 4, 2025
Owner
|
@blizzz Should that be backported for 30 as well? |
Contributor
Author
yes. 30.0.2 i think, strictly speaking, but probably 30 is good enough meanwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #189
Due to some incompatibility with shipped vue versions (started with some @nextcloud/vue versions) the workflow config frontend had to be switched to work with web components instead. The previous approach was using different shipped vue versions (by server and apps) and it only worked by luck so long.
The adapation is similar to nextcloud/files_automatedtagging#1210 and nextcloud/flow_notifications#308. The underlying server change was nextcloud/server#50783
Also bumped node and npm version specified in package.json as it does not build with the old ones.