Skip to content

Handle sample numbers > 2**31 in annotation files #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompollard merged 8 commits into from
Mar 3, 2022
Merged

Handle sample numbers > 2**31 in annotation files #328

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
04ae55f
Fix documentation of the internal variable 'filebytes'.
Sep 30, 2021
2dd4845
rdann: handle multiple consecutive SKIPs.
Sep 15, 2021
94449b8
rdann: compute timestamps as int, not a numpy integer.
Sep 30, 2021
c098e38
rdann: store sample as an array of int64.
Sep 30, 2021
481978e
wrann: allow intervals larger than 2**31 - 1.
Sep 15, 2021
0dab235
test_annotation: convert to a standard unittest.TestCase.
Sep 29, 2021
aad7b14
Add test cases for reading/writing huge skips.
Sep 29, 2021
bfa0a37
field2bytes: rearrange and add comments for clarity.
Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix documentation of the internal variable 'filebytes'. 
This variable contains the complete contents of the input annotation
file, as a numpy array of pairs of bytes (shape=(N,2), dtype='uint8').
It is neither a str nor a bytes object.
  • Loading branch information
Benjamin Moody committed Sep 30, 2021
commit 04ae55fc8f3e3c687224fd000d33feda94885769
12 changes: 6 additions & 6 deletions wfdb/io/annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,8 +1748,8 @@ def load_byte_pairs(record_name, extension, pn_dir):

Returns
-------
filebytes : str
The input filestream converted to bytes.
filebytes : ndarray
The input filestream converted to an Nx2 array of unsigned bytes.

"""
# local file
Expand All @@ -1769,8 +1769,8 @@ def proc_ann_bytes(filebytes, sampto):

Parameters
----------
filebytes : str
The input filestream converted to bytes.
filebytes : ndarray
The input filestream converted to an Nx2 array of unsigned bytes.
sampto : int
The maximum sample number for annotations to be returned.

Expand Down Expand Up @@ -1852,8 +1852,8 @@ def proc_core_fields(filebytes, bpi):

Parameters
----------
filebytes : str
The input filestream converted to bytes.
filebytes : ndarray
The input filestream converted to an Nx2 array of unsigned bytes.
bpi : int
The index to start the conversion.

Expand Down