Skip to content

Use Cases for Keyboard Avoiding View #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chirag-singhal wants to merge 1 commit into
base: mlh-fellowship-migrated-ui-changes
Choose a base branch
from
Open

Use Cases for Keyboard Avoiding View #209

chirag-singhal wants to merge 1 commit into from

Conversation

@chirag-singhal
Copy link

@chirag-singhal chirag-singhal commented Aug 13, 2020

Changelog

  • Use cases for keyboard avoiding view component

@chirag-singhal chirag-singhal self-assigned this Aug 13, 2020
@anku255 anku255 added RNTester The issues associated with the RNTester project. Final The PR that will be pointed to the facebook repo. Do not delete this branch. labels Aug 14, 2020
AnshG714
AnshG714 reviewed Aug 20, 2020
View reviewed changes
Copy link

@AnshG714 AnshG714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run this on iOS, for the height behaviour prop, the app hangs and the console reports this error: Warning: Please report: Excessive number of pending callbacks: 501. Some pending callbacks that might have leaked by never being called from native code:. Indeed, I see a long list of pending callbacks. The thing is, I'm not completely sure if this is an issue with your code because I don't see any pending promises. This might be a React Native issue?

@chirag-singhal
Copy link
Author

chirag-singhal commented Aug 21, 2020

@AnshG714 Probably a react native issue, but i don't know exactly

@anku255 anku255 removed their request for review April 6, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnshG714 AnshG714 AnshG714 left review comments

@YashKumarVerma YashKumarVerma Awaiting requested review from YashKumarVerma

@sansyrox sansyrox Awaiting requested review from sansyrox

@manyaagarwal manyaagarwal Awaiting requested review from manyaagarwal

Assignees

@chirag-singhal chirag-singhal

Labels

Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chirag-singhal @AnshG714 @anku255