[pull] master from facebook:master #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: React DevTools has gotten pretty outdated in React Native. Let's fix that! Last time I tried this it caused a lot of churn for tools like Flipper, so I approached this in two steps ([detailed in this post](https://fb.workplace.com/groups/rnsyncsquad/permalink/808063140086959/)). First was a short term plan (as implemented in [PR 21344](facebook/react#21344)) to: 1. Branch and make a patch release of DevTools 4.10 that adds a protocol check to the frontend (to detect any newer backends). 2. Upgrade Flipper (and recommend upgrade for the OSS React Native Debugger as well) to this new frontend. 3. Wait for the updated frontend to roll out. The short term plan is now done, at least for the internal build of Flipper, and both GitHub PRs to update Flipper and React Native Debugger have been merged. So this diff moves forward with the longer term plan (implemented in [PR 21331](facebook/react#21331)): 1. Add an explicit version to the protocol used by the DevTools "backend" and "frontend" components to talk to each other. 2. Check this protocol during initialization to ensure it matches. 3. Show upgrade/downgrade instructions if there's a mismatch (or if the check times out without a response– indicating an older backend). 4. Release this as 4.13. --- Changelog: [General][Changed] - Upgrade `react-devtools-core` from ~4.6.0 to ^4.13.0 Reviewed By: yungsters Differential Revision: D28103394 fbshipit-source-id: 21114294144bde9aede63cb3ba98a240082299bd
Summary: Changelog: [General] - Reflect Hermes release version from HermesBadge It was a common footgun that an unexpected version of Hermes engine is used in a RN app. To help with indicating this from the runtime, Hermes exposes its OSS release version from `HermesInternal.getRuntimeProperties()` Starting from 0.8.0. This diff updates the `HermesBadge` used by `NewAppScreen` header to reflect the version. Reviewed By: nadiia Differential Revision: D24436609 fbshipit-source-id: 8ba45be598a7d5af0e38f5044f9370fc7e1eb9a1
…HITECTURE is defined Summary: Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D28080430 fbshipit-source-id: 3e89be8419776c4a6da9dd9e8c6c5501c8f6c304
Summary: Runs an A:A react sync against the current revision to pick up the updates from the sync script. Changelog: [Internal] Reviewed By: yungsters, kacieb Differential Revision: D28103715 fbshipit-source-id: 3593909e999bdceeb95423dc37dc0ee4282963d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )