-
Notifications
You must be signed in to change notification settings - Fork 1
to prod #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feat/payouts-tests
Summary of ChangesHello @jimmyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for testing Bizum Payout transactions. The changes are helpful, but I've found a couple of areas for improvement to ensure clarity and correctness:
- Zero-width space: There's an invisible character at the end of the new heading in
docs/testing.mdthat should be removed. - Contradictory Information: The existing
cautionblock about a 5 EUR limit is now confusing with the addition of the Payouts section, which has a 10 EUR limit. I've suggested clarifying the caution to specify it applies to incoming RTP payments.
Additionally, I noticed that the file docs/guides/payouts.mdx states that 'The Payouts API is not available in the test environment,' which directly contradicts the purpose of this PR. You may want to update that file to maintain consistency across the documentation.
| | Between 10 EUR and 15 EUR | E000 (Transaction approved) | REDIRECT | | ||
| | Above 15 EUR | Phone number is not registered in Bizum | | | ||
|
|
||
| ### Test Bizum Payout transactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::caution | ||
| **In test environment Bizum only supports transactions below 5 EUR** | ||
| ::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This general caution about a 5 EUR limit is confusing, as it contradicts the new information for Payouts (which are approved below 10 EUR) and also the existing rules for regular Bizum payments (approved between 10-15 EUR in REDIRECT flow). To avoid confusion, please make this statement more specific. For example, you could clarify that it applies only to incoming RTP payments.
| :::caution | |
| **In test environment Bizum only supports transactions below 5 EUR** | |
| ::: | |
| :::caution | |
| **In the test environment, incoming Bizum payments via the RTP flow are only approved for transactions below 5 EUR.** | |
| ::: |
No description provided.