Skip to content

Backport defaultDuotone option #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajlende wants to merge 6 commits into from
Closed

Backport defaultDuotone option #12

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40418ea
Squashed commits from WordPress/gutenberg#38681
Feb 16, 2022
f2f1a7d
Move where duotone rendering happens
Feb 16, 2022
41080f4
Only render SVGs on edit-post in admin
Feb 17, 2022
18bcda6
Check block editor differently
Feb 17, 2022
e6ae1e1
Fix comment for wp_global_styles_render_svg_filters
Feb 17, 2022
203c064
Fix doc comment for get_metadata_boolean
Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix doc comment for get_metadata_boolean
  • Loading branch information
Alex Lende committed Feb 17, 2022
commit 203c0640c8a1bcf8ea6f0b6dc846d3271d61ca99
1 change: 1 addition & 0 deletions src/wp-includes/class-wp-theme-json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,6 +1655,7 @@ public function get_svg_filters( $origins ) {
*
* @param array $data The data to inspect.
* @param bool|array $path Boolean or path to a boolean.
* @param bool $default Default value if the referenced path is missing.
* @return boolean
*/
private static function get_metadata_boolean( $data, $path, $default = false ) {
Copy link
Owner

@Mamaduka Mamaduka Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use old logic from should_override_preset instead of introducing a new method and removing the old one?

This method won't be private after WordPress#2322.

Copy link
Author

@ajlende ajlende Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible. I would strongly advise against using the old one.

The old method is confusing because it returns either the boolean or the inverse of the boolean when a path is passed. Making the return consistent—the boolean or the boolean at the end of a path—is much easier to understand. And it doesn't require checking if the path argument is an array at both the call site and the method.

Expand Down