Skip to content

Fix ManagedQuicListener.LocalEndpoint #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManickaP merged 1 commit into from
Sep 13, 2023
Merged

Fix ManagedQuicListener.LocalEndpoint #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Quic/ref/System.Net.Quic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public sealed partial class ManagedQuicListener : System.Net.Quic.QuicListener,
{
internal ManagedQuicListener() : base (default(bool)) { }
public static new bool IsSupported { get { throw null; } }
public System.Net.IPEndPoint ListenEndPoint { get { throw null; } }
public override System.Net.IPEndPoint LocalEndPoint { get { throw null; } }
public override System.Threading.Tasks.ValueTask<System.Net.Quic.QuicConnection> AcceptConnectionAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public override System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
public static new System.Threading.Tasks.ValueTask<System.Net.Quic.QuicListener> ListenAsync(System.Net.Quic.QuicListenerOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
Expand Down
6 changes: 2 additions & 4 deletions ...raries/System.Net.Quic/src/System/Net/Quic/Implementations/Managed/ManagedQuicListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ private ManagedQuicListener(QuicListenerOptions options)
{
options.Validate(nameof(options));

var listenEndPoint = options.ListenEndPoint ?? new IPEndPoint(IPAddress.Any, 0);

var channel = Channel.CreateBounded<ManagedQuicConnection>(new BoundedChannelOptions(options.ListenBacklog)
{
SingleReader = true,
Expand All @@ -37,11 +35,11 @@ private ManagedQuicListener(QuicListenerOptions options)
});

_acceptQueue = channel.Reader;
_socketContext = new QuicServerSocketContext(listenEndPoint, options, channel.Writer, TlsFactory.Default);
_socketContext = new QuicServerSocketContext(options.ListenEndPoint, options, channel.Writer, TlsFactory.Default);
_socketContext.Start();
}

public IPEndPoint ListenEndPoint => _socketContext.LocalEndPoint;
public override IPEndPoint LocalEndPoint => _socketContext.LocalEndPoint;

public override async ValueTask<QuicConnection> AcceptConnectionAsync(CancellationToken cancellationToken = default)
{
Expand Down