Skip to content

Conversation

@ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jan 5, 2023

Description

closes: #964

Adds new runtime API, close: #756

Minor changes to client

No relevant runtime migrations


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@ferrell-code ferrell-code added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency L-changed Log: Issues and PRs related to changes R-polkadot-v0.9.28 labels Jan 5, 2023
@ferrell-code ferrell-code changed the title Fer bump v0.9.28 Bump Polkadot Dependencies to v0.9.28 Jan 5, 2023
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
@Dengjianping
Copy link
Contributor

Dengjianping commented Jan 16, 2023

There're some notable changes we should know probably.

  1. Cli change(v0.9.28): Rename --pruning and --keep-blocks to be more similar to one another.
    Rename --pruning and --keep-blocks to be more similar to one another paritytech/substrate#11934
    I suppose it might affect devops team @grenade .
  2. Transaction payment(mentioned above, v0.9.28): Transaction payment runtime api: query call info and fee details.
    Transaction payment runtime api: query call info and fee details paritytech/substrate#11819
    Fullstack team might be affected, or they should know this change @Kevingislason
  3. New sub command(v0.9.27): CLI flag to configure tx ban duration
    CLI flag to configure tx ban duration paritytech/substrate#11786
  4. Add benchmark extrinsic command(v0.9.27): Add benchmark extrinsic command paritytech/substrate#11456

@ferrell-code
Copy link
Contributor Author

There're some notable changes we should know probably.

Yeah good point.

Number 2 is additive, the motivation for PR was to predict XCM transact weight, could potentially be useful on frontend/sdk? Shouldn't break any existing code

Number 4: Is left Unsupported in this PR, we can support it in future if we find use for it

@Garandor
Copy link
Contributor

Garandor commented Jan 16, 2023

  1. is backward-compatible so no breakage

  1. is something for @Kevingislason to be aware of for user support and clearly showing that a user has been banned from transacting for 5 mins

Signed-off-by: Charles Ferrell <[email protected]>
Garandor
Garandor previously approved these changes Jan 16, 2023
@Garandor Garandor self-requested a review January 17, 2023 00:43
@Garandor Garandor dismissed their stale review January 17, 2023 00:57

lightclient shortcircuit

@Garandor Garandor merged commit df433ad into manta Jan 17, 2023
@Garandor Garandor deleted the fer-bump-v0.9.28 branch January 17, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency L-changed Log: Issues and PRs related to changes R-polkadot-v0.9.28

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to polkadot-v0.9.28 Expose new Transaction payment Runtime API

5 participants