Fix for allowing some version that were invalid #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NewVersion function, which uses the loose parser, had the regex for detection updated based on the official one. A change was made to allow for versions like 1.2 and other "loose" ones (to use the node semver term). StrictNewVersion had some internal validation updated to catch issues. For NewVersion, the benchmarking is now faster than the previous regex. Ref Masterminds#211 Signed-off-by: Matt Farina <[email protected]>
tacdom
pushed a commit
to industrial-asset-hub/asset-link-sdk
that referenced
this pull request
Nov 26, 2024
fix(deps): update module github.com/masterminds/semver/v3 to v3.3.1 This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/Masterminds/semver/v3](https://github.com/Masterminds/semver) | require | patch | `v3.3.0` -> `v3.3.1` | --- ### Release Notes <details> <summary>Masterminds/semver (github.com/Masterminds/semver/v3)</summary> ### [`v3.3.1`](https://github.com/Masterminds/semver/releases/tag/v3.3.1) [Compare Source](Masterminds/semver@v3.3.0...v3.3.1) #### What's Changed - Fix for allowing some version that were invalid by [@​mattfarina](https://github.com/mattfarina) in Masterminds/semver#253 **Full Changelog**: Masterminds/semver@v3.3.0...v3.3.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- :tools: with :heart: by the [DevOps Automation Bot](https://code.siemens.com/devops.automation) <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNCIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> See merge request common-device-management/shared/cdm-dcd-sdk!21 Merged-by: Swati Shinghal <[email protected]>
xoxys
added a commit
to thegeeklab/wp-plugin-go
that referenced
this pull request
Dec 10, 2024
…115) BREAKING CHANGE: Due to an upstream change in [Masterminds/semver](Masterminds/semver#253) versions like `22.04` are now invalid even when using with `strict: false`. Although this behavior is more correct, this change could lead to issues in some cases and require adjustments. Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robert Kaussow <[email protected]>
rain-c30s
approved these changes
Jan 31, 2025
|
@mattfarina just a heads up that this changed released in a patch version v3.3.1 broke Flux, Argo and probably any other consumer of this package that deals with Helm charts. Turns out many Helm users don't actually follow semver and use a leading 0 on a number segment e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NewVersion function, which uses the loose parser, had the regex for detection updated based on the official one. A change was made to allow for versions like 1.2 and other "loose" ones (to use the node semver term).
StrictNewVersion had some internal validation updated to catch issues.
For NewVersion, the benchmarking is now faster than the previous regex.
Ref #211