allow setting background of menu item #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I did not create a separate issue for this. Feel free to let me know if you want me to create one. @Xaalek I guess this is related to your recent work on the menus. |
Keboo
approved these changes
Apr 15, 2022
Member
Keboo
left a comment
Keboo
left a comment
There was a problem hiding this comment.
Great work! Thank you for the contribution!
Keboo
added
enhancement
release notes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version I unfortunately could not easily change the background of a menu. Setting the background property on a MenuItem simply had no effect. Here the result of the included sample code where the foreground change is applied but not the background which results in white on white:
With the changes in this pull request the result changes to this:
A common use case would use the same color for both the main and child menu items but I used different colors for illustration.