Skip to content

Fix for Demo app DataGrid - "Select all" checkbox not working #3032 #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 2 commits into from
Jan 22, 2023
Merged

Fix for Demo app DataGrid - "Select all" checkbox not working #3032 #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac357f9
fix(MaterialDesignDemo):Datagrids select all checkbox binding (#3032)
Hadramet Jan 22, 2023
e537bc7
fix(MaterialDesignDemo3):DataGrids select all checkbox binding (#3032)
Hadramet Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions MainDemo.Wpf/DataGrids.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,20 @@
SelectedIndex="0" />
</StackPanel>

<FrameworkElement x:Name="DataContextProxy" DataContext="{Binding}"/>

<smtx:XamlDisplay UniqueKey="grids_1">
<DataGrid AutoGenerateColumns="False"
CanUserAddRows="False"
HeadersVisibility="All"
ItemsSource="{Binding Items1}"
SelectionUnit="{Binding ElementName=selectionUnitComboBox, Path=SelectedValue}">
<DataGrid.Resources>
<domain:BindingProxy x:Key="DataContextProxy" Data="{Binding}" />
</DataGrid.Resources>

<DataGrid.Columns>
<!-- by default a DataGridCheckBoxColumn will have the MaterialDesignDataGridCheckBoxColumnStyle and MaterialDesignDataGridCheckBoxColumnEditingStyle applied. See DataGridAssist.ApplyMaterialDesignColumnStyles attached property -->
<DataGridCheckBoxColumn Binding="{Binding IsSelected, UpdateSourceTrigger=PropertyChanged}">
<DataGridCheckBoxColumn.Header>
<Border Background="Transparent">
<CheckBox IsChecked="{Binding Data.IsAllItems1Selected, Source={StaticResource DataContextProxy}}" />
<CheckBox IsChecked="{Binding DataContext.IsAllItems1Selected, Source={x:Reference DataContextProxy}}" />
</Border>
</DataGridCheckBoxColumn.Header>

Expand Down
13 changes: 0 additions & 13 deletions MainDemo.Wpf/Domain/BindingProxy.cs
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions MaterialDesign3.Demo.Wpf/DataGrids.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,20 @@
<StackPanel>
<TextBlock Style="{StaticResource MaterialDesignHeadline5TextBlock}" Text="Custom Columns" />

<FrameworkElement x:Name="DataContextProxy" DataContext="{Binding}"/>

<smtx:XamlDisplay UniqueKey="grids_1">
<DataGrid AutoGenerateColumns="False"
CanUserAddRows="False"
HeadersVisibility="All"
ItemsSource="{Binding Items1}">
<DataGrid.Resources>
<domain:BindingProxy x:Key="DataContextProxy" Data="{Binding}" />
</DataGrid.Resources>

<DataGrid.Columns>
<DataGridCheckBoxColumn Binding="{Binding IsSelected, UpdateSourceTrigger=PropertyChanged}"
EditingElementStyle="{StaticResource MaterialDesignDataGridCheckBoxColumnEditingStyle}"
ElementStyle="{StaticResource MaterialDesignDataGridCheckBoxColumnStyle}">
<DataGridCheckBoxColumn.Header>
<Border Background="Transparent">
<CheckBox IsChecked="{Binding Data.IsAllItems1Selected, Source={StaticResource DataContextProxy}}" />
<CheckBox IsChecked="{Binding DataContext.IsAllItems1Selected, Source={x:Reference DataContextProxy}}" />
</Border>
</DataGridCheckBoxColumn.Header>

Expand Down
13 changes: 0 additions & 13 deletions MaterialDesign3.Demo.Wpf/Domain/BindingProxy.cs
View file
Open in desktop

This file was deleted.