Fix PasswordBox keyboard focus traversal issue #3096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaihenriksen
changed the title
nicolaihenriksen
changed the title
nicolaihenriksen
changed the title
Keboo
approved these changes
Feb 23, 2023
Contributor
Author
|
@Keboo I changed the UI test code to match the syntax I use in the PR I have on XAMLTest. The test now fails, but it should highlight what I would like to do, and it should pass if the XAMLTest PR is merged and new version pulled in here. |
Keboo
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3095
This PR fixes the keyboard focus traversal associated with the "reveal style" password box. See the associated issue for details.
I updated the Smart Hint demo page to easily test this out.
I also added a UI test to verify the fix as well, however I was only able to get the "forward tabbing" to work. Either I don't know the correct syntax, or XAMLTest does not behave nicely with the special codes for SHIFT/CTRL/ALT modifiers which are mentioned approximately halfway down on this page:
https://learn.microsoft.com/dotnet/api/system.windows.forms.sendkeys.send
(I know this is Windows Forms link, but I assume XAMLTest is just using the same underlying P/Invoke calls?)
I left the "backwards tabbing" in the test, but commented out the assertions with FIXMEs attached. Perhaps you know the correct syntax to get this working?