Skip to content

Refactor PopupBox placement to respect configurable elevation #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 8 commits into from
Apr 8, 2023
Merged

Refactor PopupBox placement to respect configurable elevation #3136

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1777ed
Add failing UI test
nicolaihenriksen Mar 11, 2023
dbe3a64
Fix Card clipping issue
nicolaihenriksen Mar 11, 2023
d995ab6
Refactor PopupBox custom popup placement
nicolaihenriksen Mar 11, 2023
0dd2e87
Add dedicated demo app page for PopupBox
nicolaihenriksen Mar 11, 2023
cc4bf65
Small cleanup done during review on stream
Keboo Mar 16, 2023
d45e5b9
Change implementation to dedicated DP
nicolaihenriksen Apr 3, 2023
1988f83
Fix PopupTest to use new dedicated DP
nicolaihenriksen Apr 3, 2023
f462017
Moving converters inside of the tempalate
Keboo Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Card clipping issue 
Fixes issue where Card.ContentClip was not correctly updated based on changes to the UniformCornerRadius.
  • Loading branch information
@nicolaihenriksen
nicolaihenriksen committed Apr 2, 2023
commit dbe3a64923927e907bb9909d692d67fcb2f227be
13 changes: 12 additions & 1 deletion MaterialDesignThemes.Wpf/Card.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@ public double UniformCornerRadius
}
public static readonly DependencyProperty UniformCornerRadiusProperty
= DependencyProperty.Register(nameof(UniformCornerRadius), typeof(double), typeof(Card),
new FrameworkPropertyMetadata(DefaultUniformCornerRadius, FrameworkPropertyMetadataOptions.AffectsMeasure));
new FrameworkPropertyMetadata(DefaultUniformCornerRadius, FrameworkPropertyMetadataOptions.AffectsMeasure, UniformCornerRadiusChangedCallback));

private static void UniformCornerRadiusChangedCallback(DependencyObject d, DependencyPropertyChangedEventArgs e)
{
Card card = (Card) d;
card.UpdateContentClip();
}

#endregion

#region DependencyProperty : ContentClipProperty
Expand Down Expand Up @@ -59,7 +66,11 @@ public override void OnApplyTemplate()
protected override void OnRenderSizeChanged(SizeChangedInfo sizeInfo)
{
base.OnRenderSizeChanged(sizeInfo);
UpdateContentClip();
}

private void UpdateContentClip()
{
if (_clipBorder is null)
{
return;
Expand Down